QAZIMAAZARSHAD / Income-Tax-Calculator

Income Tax Calculation System For A Salaried Person
https://github.com/QAZIMAAZARSHAD/Income-Tax-Calcultor/blob/main/README.md
MIT License
36 stars 57 forks source link

Add links to these gifs #51

Closed Umesh-01 closed 3 years ago

Umesh-01 commented 3 years ago

I think these two gifs (see the below image) should contain a links to the related files because there are the chances the anyone can click on them and these are of no use. So it must redirect us to the pages where these files are present.

image

Umesh-01 commented 3 years ago

@QAZIMAAZARSHAD Should I do these changes??

QAZIMAAZARSHAD commented 3 years ago

Sure.

QAZIMAAZARSHAD commented 3 years ago

Nothing has changed.

On clicking images it should direct to code of conduct and license page

Umesh-01 commented 3 years ago

Nothing has changed.

On clicking images it should direct to code of conduct and license page

Yes it was working

Umesh-01 commented 3 years ago

@QAZIMAAZARSHAD wait let me check...

Umesh-01 commented 3 years ago

Hey @QAZIMAAZARSHAD what that revert PR means??

My PR is working I checked it

Check it here-- https://github.com/QAZIMAAZARSHAD/Income-Tax-Calcultor/pull/52/files?short_path=b335630#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5

Here in rich difference you can check, now when clicking on gifs it is taking us to the related page....

Umesh-01 commented 3 years ago

@QAZIMAAZARSHAD sir why this is open, my PR is working...

Umesh-01 commented 3 years ago

sir my contributiion is working na??

it will be counted??

QAZIMAAZARSHAD commented 3 years ago

sir my contributiion is working na??

it will be counted??

yes absolutely

Umesh-01 commented 3 years ago

sir my contributiion is working na?? it will be counted??

yes absolutely

thank u sir... 🙂

QAZIMAAZARSHAD commented 3 years ago

You can open the same issue in my other two projects, movie streaming website and voters registration portal.

If you want to earn more points.

Umesh-01 commented 3 years ago

Okk sir, thanks for the suggestion.. 🙂 I will do it now...