QB64Team / qb64

BASIC for the modern era.
https://www.qb64.org
Other
671 stars 96 forks source link

Mac: $PATH issue when converting QB4.5 files in another directory #44

Closed johnkharvey closed 4 years ago

johnkharvey commented 4 years ago

Describe the bug Hello! Whenever I try to convert a QB45 .bas file, it fails because it can no longer find the 'internal' folder.

QB64 info (please complete the following information):

To Reproduce Steps to reproduce the behavior: 1) Download the mac tarball 2) Un-tar it 3) cd qb64 4) Run ./qb64 (note that the internal folder is here) 5) The tool will start fine (all is well so far) 6) File->Open (Open your .bas file. Mine was at ../bas/file.bas) 7) "QuickBASIC 4.5 binary format detected. Convert to plain text?" (Yes) 8) "QB64 cannot locate the 'internal' folder"

It's almost like the tool forgot its pathing when I was searching for the .bas file in a different sub-directory tree.

Expected behavior I would expect the conversion to start instead of a $PATH failure

Screenshots If necessary, I can attach these, but it's a pretty straightforward procedure to reproduce with a clean error message.

Additional context I'm happy to test things however you need. I feel like as a workaround ,I could potentially put the qb45 binary and the 'internal' folder in /usr/local/bin so that they're both always on the path, but it's a little weird to put a non-binary folder in /usr/local/bin. Or, I could potentially add a bunch of things to my $PATH. If that happens to be the answer, my request would be to update the README.md installation instructions for mac, since they imply that the running the qb64 binary where it installs is sufficient, but that appears to be untrue.

I hope this is helpful!

FellippeHeitor commented 4 years ago

Please try compiling a simple PRINT "Hello world". If that works, the path issue is only regarding the conversion tool, then it'll be easier to fix.

Also, if you can, please share the .bas you're trying to convert.

FellippeHeitor commented 4 years ago

Nevermind. I thought I'd fixed that a while back but I apparently only intended to.

It's fixed now (4b28605cbe7cc23633760a4e32df504507e13608), please get the latest development build from https://www.qb64.org/portal/development-build/ and you'll be good to go (tested under macOS Catalina).

If anything wrong still goes on, please comment here and I'll reopen the issue. Thanks for reporting!

johnkharvey commented 4 years ago

Just commenting that the fix works for mac! Thank you!

FellippeHeitor commented 4 years ago

Thanks for the feedback!