QUVA-Lab / COMBO

Other
45 stars 18 forks source link

Adjacency matrix for Branin task #7

Open KamilDre opened 2 years ago

KamilDre commented 2 years ago

Hi,

I noticed that you multiply the adjacency matrix for the Branin task by (n_v - 1) in line 22 of discretized_continuous.py. Why is this the case?

ChangYong-Oh commented 2 years ago

Sometimes, I multiply adj. mat. with some constant for numerical stability. The number is chosen by checking kernel values with some preliminary kernel computations before doing BO experiments. This is in a sense adjusting the prior on beta by scaling. So it is possible to adjust the priors whenever combinatorial graph size varies, but multiplying adj. mat. with constant makes BO runs consistently with the same prior independent with the combinatorial graph size.

On Tue, Mar 8, 2022 at 1:14 AM KamilDre @.***> wrote:

Hi,

I noticed that you multiply the adjacency matrix for the Branin task by (n_v

  • 1) in line 22 of discretized_continuous.py. Why is this the case?

— Reply to this email directly, view it on GitHub https://github.com/QUVA-Lab/COMBO/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJKCMDCOVLJEYJGWHECZVLU6YTOTANCNFSM5QDYDPEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

KamilDre commented 2 years ago

Would you mind sharing some more information on how you "check" the kernel values and what do you compare them against to choose this scaling constant to improve stability? This would be of great help when applying COMBO to new problems.

ChangYong-Oh commented 2 years ago

What I did is nothing special. Because I applied to COMBO to kind of high dimensional problems in which there are 20~60 variables, kernel computation becomes the product kernel of that many kernels. So zero from numerical truncation or inf can happen. So I just checked computed kernels have reasonable values, not too many zero and no inf or nan. beta is chosen randomly from the prior I used.

On Tue, Mar 8, 2022 at 6:31 PM KamilDre @.***> wrote:

Would you mind sharing some more information on how you "check" the kernel values and what do you compare them against to choose this scaling constant to improve stability? This would be of great help when applying COMBO to new problems.

— Reply to this email directly, view it on GitHub https://github.com/QUVA-Lab/COMBO/issues/7#issuecomment-1061577880, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJKCMDQXNOSJTSYH6M3IILU64M6DANCNFSM5QDYDPEQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>