QW-Group / ktx

KTX: a QuakeWorld server modification
GNU General Public License v2.0
51 stars 47 forks source link

ISSUE: When switching gamemodes on/off settings don't reset #59

Open zalon opened 5 years ago

zalon commented 5 years ago

I'm posting this here (even tho the biggest issues are within nQuakesv), since the ktx test servers at london.badplace.eu has the same issues.

When switching gamemodes on/off, some settings will not be reset (both from mode configs and hardcoded settings).

Examples
    Turning on Rocket Arena (/arena)
    These settings will be set from mode config
        k_exclusive 0
        k_spectalk 1
        k_count 3 (nQuakesv)

    Unwanted behaviour after turning off Rocket Arena
        k_exclusive 0 makes the number of players no longer locked on game start
        k_spectalk 1 enables spectalk
        k_count 3 will leave the countdown at only 3 seconds

    These settings won't change until the server resets and reloads the default config (after being empty for a while)

    Turning on Clan Arena (/carena)
    These settings will be set by being hardcoded in ktx
        k_clan_arena_rounds 9
        dp 0
        teamplay 4
        deathmatch 5
        k_overtime 0
        k_spw 1
        k_dmgfrags 1
        k_noitems 1

    I'm uncertain if all of these settings will change on mode or map change (some do), but they stay when disabling Clan Arena

    Turning on Free For All (/ffa)
    These settings will be set from mode config
        timelimit 10
        teamplay 0
        deathmatch 3
        k_overtime 2
        k_pow 0
        k_idletime 180
        k_vwep 1 (nQuakesv)

    Unwanted behaviour after turning off Free For All
        k_vwep 1 will keep vweps enabled until the server resets and reloads the default config (after being empty for a while)

I propose setting proper defaults for all of these settings in the mode configs

tcsabina commented 1 year ago

Hey @zalon,

Just came across this issue... What happens if you set a new usermode, like /1on1 after you have disabled /arena for example? It is a bit tricky when the server 'leaves' a certain user mode. Main focus has been on what settings to execute when a certain gamemode is being activated, and not on what to do when leaving a game mode. I don't say there is nothing to be done. I just want to know if a quick /1on1 or /4on4 puts the server back to normal.