QW-Group / mvdsv

MVDSV: a QuakeWorld server
GNU General Public License v2.0
59 stars 56 forks source link

old embedded pcre version #40

Open leegarrett opened 5 years ago

leegarrett commented 5 years ago

src/pcre/* contains an antique pcre (3?) version, that also gets statically linked into the binary during build. I'll see if I can update it to current versions, and also change the build to preferentially use the system version.

I'll see if I can get a working PR done today.

FYI, this is (with the missing man page) the only remaining blocker for including mvdsv in Debian.

leegarrett commented 2 years ago

This is apparently fixed in newer builds when libpcre3-dev is installed on the system.

namtsui commented 2 years ago

This should be reopened because the build system has moved from meson to cmake with mvdsv 0.35. cmake links against internal pcre and does not offer the option of linking against system pcre.

This might also be a blocker in OpenBSD ports, so thanks for raising this issue about using the ancient bundled pcre.

tcsabina commented 2 years ago

You are right. Either we should update the contained pcre, or give the option to use the system provided pcre stuff.

Willing to contribute? ;)

tdm4 commented 2 years ago

@tcsabina I've added a PR #101 that searches for pcre library and links against it if found. if you'd like to have a look? Apologies if it is pretty rough. This is my first time doing much of anything with CMake.

cc: @namtsui

tdm4 commented 2 years ago

@tcsabina I think PR #101 should be in a good enough state to merge now? Let me know if I need to change anything. Thanks!

bgermann commented 1 year ago

pcre is abandoned. Please move to pcre2, which is pcre's successor.