Qeepsake / react-native-images-collage

Robust interactive image collage component for React Native
MIT License
116 stars 30 forks source link

Swapping does not work with duplicate images #13

Open lukebrandonfarrell opened 5 years ago

lukebrandonfarrell commented 5 years ago

Description

Swapping images does not work when there are multiple instances of the same image in the collage. This is because swapping uses the URL of the image for indexing, if there is a duplicate image, then two identical URLs exist in the images array and this will cause strange behaviour when swapping.

Solution

A possible solution would be to build a local state array from the images prop each with unique IDs, then use the unique ID to identify each image when swapping.

Steps to Reproduce

Build a collage with duplicate images.

swapping