search

Qeepsake / react-native-images-collage

Robust interactive image collage component for React Native
MIT License
116 stars 30 forks source link

Fixed the index issue #8

Closed dhanababum closed 5 years ago

dhanababum commented 5 years ago

which will resolve the touch pinch zoom in/out issue This issue is related to Pinch zooming not working

lukebrandonfarrell commented 5 years ago

@dhanababum

Thanks for your contribution!

I've tested this fix and it gives me:

screen shot 2018-12-21 at 22 45 58

React : 16.6.3 RN: 0.57.8

What versions are you running, in which this fix works for you?

dhanababum commented 5 years ago

I am using, "react": "16.2.0" "react-native": "0.52.0"

lukebrandonfarrell commented 5 years ago

@dhanababum

Thanks! I'll give it a test in the next few days.

lukebrandonfarrell commented 5 years ago

@dhanababum

Think we've fixed the issue. The collage component multi-touch will not work when placed in a react-native Modal component. I am going to update the README soon.

lukebrandonfarrell commented 5 years ago

@dhanababum Sorry my bad, this was a Android specific issue, your fixed would have worked, but only for Android. Version 3.2.1 fixes this issue by removing undefined from the touchBank.

Thanks for your contribution.