Open stephlazar opened 5 years ago
Thanks for raising the issue. My opinion is that we should address both points you have mentioned ;)
what was the purpose of the condition to continue only if MC.percdone() returned less than 100 ? Can we continue until we don't have any soft sweep points ?
ssro should return correct percentage also. Can we do that without an if statement ?
I merged the fix by Steph into qudev_master now, but it should still be tested that it is fixed on a real setup before closing
@stephlazar @nathlacroix Have you seen this issue this year?
yes I'm pretty sure I did. I didn't get to spend time to try to fix it though.
At some point, we changed from setting MC.sweep points(nr_sweep_points x nr_shots) in the measure function and UHFQC.quex_rl_length(nr_shots) in the detector function, to setting MC.sweep points(nr_sweep_points) and UHFQC.quex_rl_length(nr_sweep_points x nr_shots). The side effect of this is that now the MC.get_percdone() returns nr_shots % instead of 100 % when one acquisition is done.
This side effects broke the ability to do 2D sweeps with the SSRO detector because the MC only proceeds to the next acquisition in the 2D sweep is MC.get_percdone() < 100.
To solve, we probably need to either: