QudevETH / PycQED_py3

Python3 version of PycQED using QCodes as backend
MIT License
9 stars 7 forks source link

2D sweeps with the UHFQC_integration_logging_detector broken #21

Open stephlazar opened 5 years ago

stephlazar commented 5 years ago

At some point, we changed from setting MC.sweep points(nr_sweep_points x nr_shots) in the measure function and UHFQC.quex_rl_length(nr_shots) in the detector function, to setting MC.sweep points(nr_sweep_points) and UHFQC.quex_rl_length(nr_sweep_points x nr_shots). The side effect of this is that now the MC.get_percdone() returns nr_shots % instead of 100 % when one acquisition is done.

This side effects broke the ability to do 2D sweeps with the SSRO detector because the MC only proceeds to the next acquisition in the 2D sweep is MC.get_percdone() < 100.

To solve, we probably need to either:

nathlacroix commented 5 years ago

Thanks for raising the issue. My opinion is that we should address both points you have mentioned ;)

antsr commented 4 years ago

I merged the fix by Steph into qudev_master now, but it should still be tested that it is fixed on a real setup before closing

antsr commented 4 years ago

@stephlazar @nathlacroix Have you seen this issue this year?

stephlazar commented 4 years ago

yes I'm pretty sure I did. I didn't get to spend time to try to fix it though.