Closed TheGlitch76 closed 3 years ago
provides
should be allowed to provide a Maven group. It is a relatively infrequently used feature, however, and I believe that if somebody wants to provide a "reserved" namespace they might as well be able to.ProvidesObject
to me? You replaced the single DependencyObject
with an array of ProvidesObject
s in your changes, which makes me wonder why you claim the array behavior of DependencyObject
is not needed. I could also see a situation arising where unless
would be useful for provides
, so am wary to remove that as well.which makes me wonder why you claim the array behavior of DependencyObject is not needed.
The array behavior is "any", not "all", which makes no sense for a provides
object
While it might not make sense in that a mod wouldn't provide any of the items in provides, it does correlate better to matching dependencies. That being said, I can understand these changes and if a use case arises in the future where unless
or the array variant is needed, we can always add it.
The summary of changes, and their reasoning:
.
,-
, or_
(I am willing to expand this if needed)loader.plugin.
is reserved for use by plugins, for example fabric mods would be under the implicit grouploader.plugin.fabric.modid
provides
though, should it be? Or shouldprovides
not be allowed to define a maven group at all?ProvidesObject
instead of aDependencyObject
--some fields of DependencyObject needlessly complicate implementation or are simply not needed (for example, the array behavior of a dependency object)