search

QuiltMC / rfcs

Repository for requests for comments for proposing changes to the Quilt Project.
Other
61 stars 33 forks source link

RFC 32: Quilt Loader Plugins #32

Closed Haven-King closed 3 years ago

Haven-King commented 3 years ago

Rendered view

TheGlitch76 commented 3 years ago

I'd like to see Chocohead's comments addressed before this PR is merged.

Haven-King commented 3 years ago

I'd like to see Chocohead's comments addressed before this PR is merged.

I definitely did not forget to click "submit review". That could never happen.

Haven-King commented 3 years ago

At this point I am moving this RFC into the final comment period, despite the lack of comments so far. It is likely that much of what has been laid out in this RFC will change throughout development, but this idea is core to a lot of the technical changes Quilt aims to make, so it is crucial that we get work started on this.

The final comment period will close on August 4th.

mschae23 commented 3 years ago

In the "API Surface" part, you're using Futures as parameters that will be called.

If that is Future from Java, that's not correct. Futures can't be called, they're just delayed suppliers.

I'd suggest a custom functional interface for that, in this case.