search

QuiltMC / rfcs

Repository for requests for comments for proposing changes to the Quilt Project.
Other
61 stars 33 forks source link

Support Sided Mixins #89

Closed OroArmor closed 7 months ago

OroArmor commented 7 months ago

See https://github.com/QuiltMC/quilt-loader/pull/395

Ampflower commented 7 months ago

Doesn't Mixin already natively support this via client and server? Curious, why duplicate the work that already exists?

FirstMegaGame4 commented 7 months ago

the issue here is that quilt loader doesn't parse sided mixins in qmj

OroArmor commented 7 months ago

This adds support for something already in Fabric Loader. The main use for this feature is for split-source mods, as this allows the client mixins to have their own separate mixin config. I could see a small use case for a mixin that has a different effect on the server vs the client.

AlexIIL commented 7 months ago

Final comment period ends in 3 days on January 16th.

MattiDragon commented 7 months ago

There seems to be a stray "Providing" at the end of the mixin section. Is that intentional?

OroArmor commented 7 months ago

There seems to be a stray "Providing" at the end of the mixin section. Is that intentional?

Thanks