search

Quorafind / Outliner.MD

https://outliner.md
161 stars 2 forks source link

Bug: global search shortcut and editing toolbar plugin #51

Closed lifehaschanged closed 3 months ago

lifehaschanged commented 4 months ago

I discovered 2 bugs that seem important:

  1. Add a shortcut to global search (the search sidebar of obsidian should open)
  2. Go in outliner view and press global search shortcut
  3. look in console > can't execute global search

Another thing is compatibility with this extension: https://github.com/PKM-er/obsidian-editing-toolbar

  1. In the options of this extension select "Editing toolbar position" to "following"
  2. Select some text in the outliner view
  3. Popup after text selection doesn't appear
Quorafind commented 4 months ago

What is the shortcut you set for global search ?

lifehaschanged commented 4 months ago

Sorry, in my first post I have said global search but the name of the command is "search: search in all files". I have assigned it to ctrl+s.

lifehaschanged commented 4 months ago

I have unbound the shortcut ctrl+s before (saving the file) because I don't need it

lifehaschanged commented 4 months ago

grafik

Quorafind commented 4 months ago

Global search function would be fixed in next version

lifehaschanged commented 4 months ago

Very good!

Quorafind commented 4 months ago

0.1.5 should fix the global search hotkey issue. Could you try it when you are free?

lifehaschanged commented 4 months ago

Thanks, it's good now! Other thing:

  1. Can you try some embedded queries like this in a sandbox vault

grafik

Because very high cpu lag and have to restart the sandbox vault. Maybe option to disable editing embedded/backlinks in embedded querys?

  1. Can the sidebar global search be made to render markdown when search? Would be great > Same markdown rendering you did for backlinks

  2. When clicked on search result in search sidebar, no highlight in outliner view. Would be good.

lifehaschanged commented 4 months ago

I think the command for rename file (it's on F2 key assigned by default) is not working when in outliner.md view.

Quorafind commented 3 months ago

It would be possible to provide a button to toggle between editable and view-only modes for search results. However, Outliner.md would not make all search results editable by default.

lifehaschanged commented 3 months ago

Yes, that would be a very great addition!