R0Y15 / WeatherNow

A Weather Forecasting website that tells you precisely about weather

https://r0y15.github.io/WeatherNow/

8 stars 20 forks source link

API Key Security #36

Closed ooye-sanket closed 10 months ago

ooye-sanket commented 11 months ago

Be cautious about exposing API keys in client-side code. It's generally a good practice to keep API keys on the server-side to avoid exposing them in your client-side JavaScript.

R0Y15 commented 11 months ago

What do you have in mind? are you up to any solutions?

ooye-sanket commented 11 months ago

Yes!! I've an idea 💡 let me raise PR/

On Fri, 13 Oct 2023, 18:22 Bishal Roy, @.***> wrote:

What do you have in mind? are you up to any solutions?

— Reply to this email directly, view it on GitHub https://github.com/R0Y15/WeatherNow/issues/36#issuecomment-1761471484, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAQ2QBGBCPC5GJPR33F7P7DX7E2SDAVCNFSM6AAAAAA57CCZLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRRGQ3TCNBYGQ . You are receiving this because you authored the thread.Message ID: @.***>

R0Y15 commented 11 months ago

Yes!! I've an idea 💡 let me raise PR/ … On Fri, 13 Oct 2023, 18:22 Bishal Roy, @.> wrote: What do you have in mind? are you up to any solutions? — Reply to this email directly, view it on GitHub <#36 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BAQ2QBGBCPC5GJPR33F7P7DX7E2SDAVCNFSM6AAAAAA57CCZLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRRGQ3TCNBYGQ . You are receiving this because you authored the thread.Message ID: @.>

cool lets do it then.

elguitarraverde commented 10 months ago

Hi, I am happy to collaborate on your project. I have created a PR that I think can solve this ISSUE.

I welcome your feedback.

PR -> #46

hacktoberfest

R0Y15 commented 10 months ago

Hi, I am happy to collaborate on your project. I have created a PR that I think can solve this ISSUE.

I welcome your feedback.

PR -> #46

hacktoberfest

Well Done. Thank you