Closed KoalaGeo closed 2 years ago
Apologies for the delay here @KoalaGeo, I just didn't see the PR until merging another one today.
All good so merging.
Just note that we are working on a VocPrez v3 which is externally the same - so all your contribution will work as-is - but internally upgrades, and greatly improves, the application. Faster, easier to update etc. The first implementation of VP3 is just about to be in production for the BODC and you can see it live here: http://nvs.surroundaustralia.com/. Note the version of "NVS" which will become 3.0.0 or similar soon. V3 shares lots of code with our OGC Linked Data API (https://github.com/surroundaustralia/ogcldapi) so that delivering either vocabs (SKOS) or spatial (GeoSPARQL) information starts to look very similar. This will be useful if BGR wishes to deliver both classification vocabs and things like lists of actual rock units as Linked Data.
Oh, the one container-relevant change in VP3 is uvicorn, not gunicorn, to handle async requests. Easy to adapt to...
I like v3, very nice.
Out of interest is a openapi endpoint on the roadmap for VP? I've been looking at https://github.com/CLARIAH/grlc/ but would prefer not to have to string tools together obviously! We're got stakeholders who are keen on a API for our lexicon but are after openapi not SPARQL....
All our OGC LD APIs automatically present an OpenAPI endpoint. Part of the OGC API requirements!
So yes, VocPrez will inherit this automatic OpenAPI generation in V3.
Add GH Actions to build container & push to GH container registry (GH eqiv of DockerHub)
master branch > latest tag releases > tagged as release number
Example: https://github.com/BritishGeologicalSurvey/VocPrez/pkgs/container/vocprez
Then users can pull directly and copy in their config with Dockerfile - no docker-compose required.
Also Send gunicorn logs to stdout and stderr so they are saved in container logs