search

RETURN-project / makeDataCube

Data management
Apache License 2.0
0 stars 0 forks source link

FORCE now incorporates download of Landsat and Sentinel-2 from the cloud! #23

Closed wandadk closed 3 years ago

wandadk commented 3 years ago

The last version of FORCE has new functionality to download the Landat AND Sentinel-2 data from the Cloud (google cloud). This can simplify the makeDataCube code a lot! See https://force-eo.readthedocs.io/en/latest/howto/level1-csd.html

wandadk commented 3 years ago

@PabRod : I think it is worth exploring this new functionality, since this will allow to remove our Python functions from the R package. In addition, we can also easily download Sentinel data for the test cubes.

PabRod commented 3 years ago

Hi @wandadk,

just a warning here: the branch you used for exploring this (feature/FORCEcsd) branches from a slightly old version of master. Perhaps you forgot to pull first.

I've fixed it with this commit. I think I've fixed it cleanly, but it will be a good idea to check twice that the merge didn't destroy anything in the vignette.

If you see anything strange, let me know or, worst-case scenario, just revert the merge (the abovementioned commit https://github.com/RETURN-project/makeDataCube/commit/116527a4bbb715d85bf40285282b798c41ff5cb4).

Cheers!

wandadk commented 3 years ago

Hi @PabRod ,

Thanks! At first sight the merge shouldn't destroy anything.

If we use FORCE to download Landsat data, we don't need to load pylandsat anymore. This shouldn't however break anything.

Best, Wanda

PabRod commented 3 years ago

We incorporated this in commit: 54538a8fed22928c66889ec99ae321fdf09002f7

Another related issue: #31