search

RETURN-project / makeDataCube

Data management
Apache License 2.0
0 stars 0 forks source link

Consider passing folder structure as a list #34

Open PabRod opened 3 years ago

PabRod commented 3 years ago

Problem

Currently, each individual folder is being communicated to our methods as an individual parameter. This leads to unnecessarily long function signatures. See example below:

makeParFile(paramfolder, file.path(paramfolder, paramfile), FILE_QUEUE = file.path(queuefolder, queuefile), DIR_LEVEL2 = l2folder, DIR_LOG = logfolder, DIR_TEMP = tmpfolder, FILE_DEM = file.path(demfolder, demfile), ORIGIN_LON = '-90', ORIGIN_LAT = '60', RESAMPLING = 'NN', DIR_WVPLUT = wvpfolder, RES_MERGE = 'REGRESSION',  NPROC = '1', NTHREAD = '1', DELAY = '10', OUTPUT_DST = 'TRUE',  OUTPUT_VZN = 'TRUE', OUTPUT_HOT = 'TRUE', OUTPUT_OVV = 'TRUE', DEM_NODATA= '-32768',TILE_SIZE = '3000',BLOCK_SIZE = '300')

Solution

Pack all the folder structure into a list (for R) and/or a dictionary (for Python), and pass only this.

PabRod commented 3 years ago

We don't use makeParFile anymore.

Most of the configuration options are handled now with a data frame. We are still implementing some of the details, but the basics are already there.