refactored inheritance in tests

RGF-team / rgf

Home repository for the Regularized Greedy Forest (RGF) library. It includes original implementation from the paper and multithreaded one written in C++, along with various language-specific wrappers.

378 stars 58 forks source link

refactored inheritance in tests #264

Closed StrikerRUS closed 6 years ago

StrikerRUS commented 6 years ago

Removed duplicated code.

StrikerRUS commented 6 years ago

@fukatani May I also ask you to prepare and upload new release of rgf_python? I think that we should do it ASAP for Windows users who have updated scikit-learn to 0.20.0.

P.S. I suppose the status of this PR (merged or not) doesn't matter, since it's just tests refactoring.

StrikerRUS commented 6 years ago

@fukatani Thanks for the review! Can I merge this right now and occupy CIs? Or maybe you want prepare a new release and I can delay merging?

StrikerRUS commented 6 years ago

@fukatani Oh, wait! Seems that I'm practically finish warm-start. Let's include it in new release. Don't you mind?