[R] change internal calls to use keyword args

RGF-team / rgf

Home repository for the Regularized Greedy Forest (RGF) library. It includes original implementation from the paper and multithreaded one written in C++, along with various language-specific wrappers.

378 stars 58 forks source link

[R] change internal calls to use keyword args #267

Closed jameslamb closed 6 years ago

jameslamb commented 6 years ago

This PR addresses #244

Please do not review until we've merged #266 . I branched off of that PR to avoid dealing with merge conflicts. If/when we merge that, I'll rebase this PR and the diff will make more sense.

StrikerRUS commented 6 years ago

@jameslamb Thank you very much!

Unfortunately, Travis is unhappy. Can you please take a look?

jameslamb commented 6 years ago

yep! The fact that it passed on appveyor tells me it's probably just one of those transient travis things. I'll check.

jameslamb commented 6 years ago

Ha I was too quick to blame Travis. Totally my fault! The package uses occurences (one r) but I accidentally used occurrences (2 r's) in one place. Should be fixed as of my most recent commit

StrikerRUS commented 6 years ago

We haven't configured Appveyor for checking R-package yet :-(

Seems to be another one typo: 'tree_grain_ratio' -> 'tree_gain_ratio' (grain -> gain)

jameslamb commented 6 years ago

whoops! Fixed. I also created #268 so anyone coming to the repo knows appveyor setup is a contribution that would be welcomed.

jameslamb commented 6 years ago

Rebasing right now, now that we've merged #266

jameslamb commented 6 years ago

ok @StrikerRUS @mlampros this is ready for review!

jameslamb commented 6 years ago

Oh sure, no prob. Just updated the NEWS.md