search

RGF-team / rgf

Home repository for the Regularized Greedy Forest (RGF) library. It includes original implementation from the paper and multithreaded one written in C++, along with various language-specific wrappers.
378 stars 58 forks source link

I updated the R-package to CRAN version 1.0.6 #277

Closed mlampros closed 5 years ago

mlampros commented 5 years ago

The R-package was updated to CRAN version 1.0.6. It might take a couple of days for the Windows and OS X binaries to be built.

StrikerRUS commented 5 years ago

Are these changes from this PR in 1.0.6 at CRAN?

R is unhappy with versioning again :-(. I suppose you can update to 1.0.6.1 here to avoid the warning.

mlampros commented 5 years ago

I'm sorry, I forgot that I had to adjust the version to 4-digits. Now, it should pass the .travis checks.

mlampros commented 5 years ago

the .travis-linux is ok, however the .travis-OS X gives a WARNING. I don't know if it's related with the fact that libgit2 is not installed, 


configure: error: 
  ---------------------------------------------
   The libgit2 library that is required to build git2r was not found.
  ......
   libgit2       (Homebrew package on macOS)

or with the pandoc version in Anaconda (as indicated here and here),

Could not fetch https://r-pkg.org/badges/version/RGF
.........
StrikerRUS commented 5 years ago

@mlampros No problem! Thank you! I've re-run the failed job. Let's see...

StrikerRUS commented 5 years ago

Seems it was accidental download error... Travis is happy now.

StrikerRUS commented 5 years ago

For auto-closing the issue: closed #276

StrikerRUS commented 5 years ago

ping @fukatani for the review

StrikerRUS commented 5 years ago

@fukatani Can you please review this PR because it blocks all others.

fukatani commented 5 years ago

Ah.. really sorry. I was not aware of this PR.

StrikerRUS commented 5 years ago

Thanks, guys!