search

RGF-team / rgf

Home repository for the Regularized Greedy Forest (RGF) library. It includes original implementation from the paper and multithreaded one written in C++, along with various language-specific wrappers.
378 stars 58 forks source link

support macOS Catalina #309

Closed StrikerRUS closed 5 years ago

StrikerRUS commented 5 years ago

macOS Catalina was released in October. https://en.wikipedia.org/wiki/MacOS_Catalina

BTW, should we drop support for very old versions?

fukatani commented 5 years ago

Thank you for your PR. I think yes. If any user ask old version support, we can rethink.

Since lightgbm supports from 10.8, how about matching it?

StrikerRUS commented 5 years ago

Since lightgbm supports from 10.8, how about matching it?

10.8 was chosen just because of the automatic truncation of file name on one maintainer's Windows machine 😄 . I don't think that it makes sense to match it.

According to this article, it seems that Apple officially supports last 3 versions. What about to match that policy? Or maybe we can support last 5?.. https://www.howtogeek.com/350901/which-releases-of-macos-are-supported-with-security-updates/

fukatani commented 5 years ago

According to this article, it seems that Apple officially supports last 3 versions. What about to match that policy?

I agree with you. Last 3 versions sounds nice to me.