search

RGF-team / rgf

Home repository for the Regularized Greedy Forest (RGF) library. It includes original implementation from the paper and multithreaded one written in C++, along with various language-specific wrappers.
378 stars 58 forks source link

Use CMAKE_INSTALL_PREFIX #315

Closed ankane closed 4 years ago

ankane commented 4 years ago

Hey, thanks for this project! Currently, CMAKE_INSTALL_PREFIX is respected for RGF, but not for FastRGF. This allows CMAKE_INSTALL_PREFIX to work for FastRGF.

mkdir FastRGF/build
cd FastRGF/build
cmake .. -DCMAKE_INSTALL_PREFIX=/tmp
make install
StrikerRUS commented 4 years ago

@ankane Thanks for the kind words and this PR!

CI builds are failing... Can you please take a look?

ankane commented 4 years ago

Hey @StrikerRUS, thanks for the response here as well. It looks like the Python library needs to set -DCMAKE_INSTALL_PREFIX to the old location for this to work (guessing the R package needs something similar). CMake 3.7 introduced CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT to allow projects to set their own default prefix without breaking CMAKE_INSTALL_PREFIX, but 3.7 is a big jump from the current minimum. Since this is more involved than expected, going to close for now.

StrikerRUS commented 4 years ago

@ankane Thank you for your investigation!