search

RGF-team / rgf

Home repository for the Regularized Greedy Forest (RGF) library. It includes original implementation from the paper and multithreaded one written in C++, along with various language-specific wrappers.
378 stars 58 forks source link

[ci] changed strategy for installing R on AppVeyor #321

Closed jameslamb closed 4 years ago

jameslamb commented 4 years ago

@StrikerRUS while working on https://github.com/microsoft/LightGBM/pull/2936, I noticed that in this repo you're using a link like this to get R.exe:

appveyor DownloadFile https://cloud.r-project.org/bin/windows/base/R-${R_VERSION}-win.exe

I think that those links only work as long as that version is the latest release. In this PR, I propose changing to the /old URLs which you can rely on forever (so you can upgrade at your own pace).

StrikerRUS commented 4 years ago

@jameslamb Wow, thank you very much! I have already encountered this problem twice. I thought about using some loop with possible future version numbers but wasn't smart enough to look for the permanent link 🙂

Only one note. I think we can define R_VERSION: 3.6.2 in R-package/.R.appveyor.ps1 file to be consistent with Travis configuration: https://github.com/RGF-team/rgf/blob/ba62e1f3bbba0b1c3e7b64b6e1aef5c5892e3b42/R-package/.R.travis.sh#L16-L17

jameslamb commented 4 years ago

@jameslamb Wow, thank you very much! I have already encountered this problem twice. I thought about using some loop with possible future version numbers but wasn't smart enough to look for the permanent link 🙂

Only one note. I think we can define R_VERSION: 3.6.2 in R-package/.R.appveyor.ps1 file to be consistent with Travis configuration: https://github.com/RGF-team/rgf/blob/ba62e1f3bbba0b1c3e7b64b6e1aef5c5892e3b42/R-package/.R.travis.sh#L16-L17

sure! changed it in https://github.com/RGF-team/rgf/pull/321/commits/a3bac273fb7425151e78991cbcd26420e9587eb5