RGF-team / rgf

Home repository for the Regularized Greedy Forest (RGF) library. It includes original implementation from the paper and multithreaded one written in C++, along with various language-specific wrappers.
378 stars 58 forks source link

migrate from Travis to GitHub Actions and stop testing Python 2 #328

Closed StrikerRUS closed 3 years ago

StrikerRUS commented 3 years ago

Quite big CI refactoring. There are two main changes in this PR:

Also, during refactoring I containerized everything for Linux jobs. It greatly reduces test time and complexity of dependency management.

R-package tests now use the latest available version of R. It is 4.0.3 right now. This is great, I think!

scikit-learn version should be restricted for now because starting from 0.24.0 our integration test fails due to some values in sample-weight array are zeros. I'm going to address this issue in a follow-up PR.

StrikerRUS commented 3 years ago

Oh, forgot to mention that I'm also incrementing macOS version in Python wheel filename according to https://github.com/RGF-team/rgf/pull/309#issuecomment-555011121.

StrikerRUS commented 3 years ago

... And I haven't transferred creating i686 Linux Python wheels. I don't think that they are in demand nowadays.

fukatani commented 3 years ago

@StrikerRUS Thank you for PR!

Appveyor was failed. Could you check this?

StrikerRUS commented 3 years ago

Thanks a lot guys for reviews!

@fukatani

Appveyor was failed. Could you check this?

Ah yeah, sure! Seems that filename of installer inside zip archive has been changed. I just pushed updates in 4d28d9b14020aa366f52da5db52b5ab34b1db168. Hope it will make all checks green!

StrikerRUS commented 3 years ago

@fukatani All checks are green now! 👍 Could you please leave your review?

fukatani commented 3 years ago

LGTM Thank you for your contribution