search

ROBOTIS-GIT / Dynamixel2Arduino

DYNAMIXEL protocol library for Arduino
Apache License 2.0
88 stars 55 forks source link

Match HardwareSerial begin signature #71

Open dylantubular opened 3 years ago

dylantubular commented 3 years ago

Hi!

It would be incredibly helpful if the signature of Dynamixel2Arduino's

void begin(unsigned long baud = 57600);

matched Arduino's HardwareSerial

void begin(unsigned long baud, uint32_t config=SERIAL_8N1, int8_t rxPin=-1, int8_t txPin=-1, bool invert=false, unsigned long timeout_ms = 20000UL);

In my particular case I'm using an ESP32 as a control interface and I need to remap the pins for UART2, but because the call to begin is behind Dynamixel2Arduino::begin I have to alter the library to enable this functionality.

Cheers.

ROBOTIS-Will commented 3 years ago

Hi @dylantubular

Thank you for your suggestion regarding supporting the ESP32. Since the DYNAMIXEL2Arduino library is intended to support the official Arduino boards and ROBOTIS boards that support Arduino, I'm afraid that it would be difficult for me to spare resources to develop features for ESP32. However, if you can contribute to improve the code, it is more than welcomed and will be reviewed for release. Thank you.