search

ROBOTIS-GIT / OpenCR

Software for ROS Embedded board (a.k.a. OpenCR). OpenCR means Open-source Control Module for ROS.
Apache License 2.0
383 stars 238 forks source link

Fix precompiled libraries linkage on Arduino #294

Closed Acuadros95 closed 2 years ago

Acuadros95 commented 2 years ago

This PR fixes precompiled libraries linkage in OpenCR Arduino platform.

Purpose: We are having problems with micro-ROS for arduino library link process

Our latest implementation includes packages with repeated symbols name and as our library is within the --whole-archive linker option, we end up with a lot of multiple definition link errors.

This PR moves our library out to the --no-whole-archive part, letting the linker optimize this symbols out.

Related: https://github.com/ROBOTIS-GIT/OpenCR/pull/253 (CC: @pablogs9)

ROBOTIS-Will commented 2 years ago

@Acuadros95 Thanks for your contribution. We'll be having almost a week long Lunar New Year holiday so I'll prematurely release this update so that you can try it. Thanks!

pablogs9 commented 2 years ago

Thanks for the quick response @ROBOTIS-Will !

ROBOTIS-Will commented 2 years ago

@pablogs9 My pleasure :) Have a great weekend ahead!