[MFMA] Support 64x4 and 4x64 tile size

ROCm / triton

Development repository for the Triton language and compiler

MIT License

83 stars 27 forks source link

Closed binarman closed 7 months ago

binarman commented 8 months ago

This PR enables two new MxN tile sizes: 64 x 4 and 4 x 64. Both of them uses mfma 4x4 instructions.

binarman commented 8 months ago

During investigation of mfma layouts in reduce op I found following issues:

intra warp reduce is not working, because need to replace nDim with mDim here: https://github.com/ROCmSoftwarePlatform/triton/pull/432/files#diff-ebdcca81a5e773149f1efe1d260ad43eb8c0b58aaf5e0dc1b146673014c0721fR1223
warps in group are not ordered correctly. Swapping order getMultiDimWarpId in ReduceOpToLLVM.cpp fixes some of tests

alefimov-amd commented 7 months ago

I created new PR: #469

This PR is for reference, it introduces same functionality, but before rebase on top of #441