search

ROCm / triton

Development repository for the Triton language and compiler
MIT License
83 stars 27 forks source link

Support matmul semanthics for WMMA dot operation #436

Closed joviliast closed 5 months ago

joviliast commented 8 months ago

-Add operand types checking -Add result types conversion depending on the operands

Signed-off-by: joviliast iveselov.nn@gmail.com

alefimov-amd commented 7 months ago

I don't think this PR will be merged, because it will prevents backend integration in upstream.

zhanglx13 commented 7 months ago

@alefimov-amd Agreed It's better to push such checks in the backend. I remembered you are thinking of doing so for mfma instructions. Maybe you can work with @joviliast to figure out a better way of doing it.

zhanglx13 commented 5 months ago

closing since wmma code are upstream'ed