search

ROCm / triton

Development repository for the Triton language and compiler
MIT License
80 stars 23 forks source link

Provide correct warp size to compiler #491

Closed joviliast closed 4 months ago

joviliast commented 5 months ago

Make warp size parameter and kernel launching dependent on architecture

Signed-off-by: joviliast iveselov.nn@gmail.com

scxiao commented 5 months ago

We have a PR pull/244/ that did this before. It is a complete solution, maybe you can take a look @joviliast. Thanks

joviliast commented 5 months ago

I have a general question. How does this PR plan to live with upstream? Do we need to "copy" this PR upstream directly? Or do we need to redo everything?

Some of changes are similar, but they can't be just copied. I'll create another PR in upstream. Is it Ok?

joviliast commented 5 months ago

We have a PR pull/244/ that did this before. It is a complete solution, maybe you can take a look @joviliast. Thanks

Thank you. I'll take it as a reference

zstreet87 commented 4 months ago

LGTM @zhanglx13 what say you? We should take your question above offline because it's a good one

zhanglx13 commented 4 months ago

@zstreet87 We already have a PR upstream dealing with warpSize. Why do we need the same thing (or something very similar) in this fork?

This change makes navi configure correct warp size, so more UT tests can pass, I think.