RWTH-EBC / AixCaliBuHA

Wield this tool to be King Arthur of your models.
MIT License
10 stars 2 forks source link

43 improvement of sensitivity analysis #48

Closed HvanderStok closed 7 months ago

HvanderStok commented 1 year ago

Closes #43. The new options and changes are showcased in the new example e3_verbose_sensitivity_analysis.py .

HvanderStok commented 8 months ago

I now also added a time-dependent sensitivity analysis.

FWuellhorst commented 8 months ago

Additional todos to have everything ready for 1.0:

FWuellhorst commented 8 months ago

The results look really cool, thanks for the really good work! I added some todos directly in the code and adjusted minor text issues. Three general points:

  1. Consistent plot titles. Sometimes it is goal: Electricity, sometimes just Electricity, same for calibration classes. I would opt to have a verbose title, always specifying if the string refers to a class, a goal, or a parameter.
  2. Try tight_layout on the plots before showing / saving them. Some variable names are not inside the view. If parameter names get too long, maybe trimming them would be an option (as in the calibration logs).
  3. Consider using logging warning instead of the UserWarning. As the latter are pretty big, it often irritates users. I would warn about code deprications and wrong usage.