search

RakipInitiative / ModelRepository

Joint project of EFSA, Federal Institute For Risk Assessment, DTU and ANSES to create a online model repository.
GNU General Public License v3.0
2 stars 0 forks source link

Editor deletes simulations of read-in fskx file #183

Open Thatsreallycool opened 3 years ago

Thatsreallycool commented 3 years ago

Version: FSK 2.0.0RC2 Reading in any fskx-file with several simulation setting stored (see attached workflow), executing the Editor will delete all simulations other than default. https://app.zenhub.com/files/241333403/e7e4a734-d3a2-4b04-ad7d-6c3d22726d61/download

Further if i 'Configure' the editor and change the setting from 'Archived Environment' to 'Directory Environment' the former option becomes unavailable and if i execute the Editor afterwards, the model script, visualisation script and meta data information is lost, but the simulations are still available.

schuelet commented 3 years ago

Regarding the simulation deletion: This is only a bug in the case that the Parameters are not touched. If those are changed, then the integrity of previous simulations is no longer guaranteed.

Regarding the environment issue: switching from archive-environment to anything else would mean to abandon the model and create a new one. The most common use case is that users want to add a resource file, we need to implement that in a better and more clearer way.

schuelet commented 3 years ago

FSKX model with different predefined simulation settings, only default simulation is still available after FSKX Reader->FSK Editor->FSKX Writer The problem still applies. Also if the FSK Editor Node is only executed, NOT execute and open views, after writing the model in a new FSKX file, this file contains only the default simulation, all the other simulations are missing.

schuelet commented 3 years ago

Here is a workflow showing the missing simulations issue.

https://app.zenhub.com/files/241333403/1cd3972c-c833-42b9-88db-bc295f3395bb/download