RakipInitiative / ModelRepository

Joint project of EFSA, Federal Institute For Risk Assessment, DTU and ANSES to create a online model repository.
GNU General Public License v3.0
2 stars 0 forks source link

no simulation parameter values for some models in landingpage #259

Closed schuelet closed 3 years ago

schuelet commented 3 years ago

No actual parameter values are displayed in the simulation view on the landing page for at least these models.

ganasp commented 3 years ago

I had a look into the metadata regarding the parameters and predefined simulation settings for the two mentioned models (primary model and secondary model for Listeria). For the primary model the following parameters with their values are defined: default simulation N0 <- 1, DA_wph <- 0.0, Storage_period <- 90, Phe <- 0.0, BA_wph <- 0.0, CO2equilibrium <- 0.0, Temp <- 4.0, LA_wph <- 0.0, NIT <- 0.0, pH <- 6.2, NaCl <- 4.0, CA_wph <- 0.0, AA_wph <- 0.0, SA_wph <- 0.0. For the secondary model the following parameters with their values are defined: default simulation P <- 0, CO2equilibrium <- 0.0, Temp <- 10, LA_wph <- 10, DA_wph <- 10, NIT <- 0, pH <- 6.0, NaCl <- 0.6, CA_wph <- 10, AA_wph <- 10, SA_wph <- 10, BA_wph <- 10 ham simulation P <- 0, CO2equilibrium <- 0.0, Temp <- 10, LA_wph <- 10, DA_wph <- 10, NIT <- 0, pH <- 5.1, NaCl <- 0.6, CA_wph <- 10, AA_wph <- 10, SA_wph <- 10, BA_wph <- 10. Regarding the question, why these parameters are not displayed with their corresponding values in the simulation view, I can only say, that for these models and their simulation settings the minimum values for the parameters are displayed in the simulation view instead of the values for the parameters. All parameters have predefined values, minValues and maxValues and this information is given as metadata of the models.

schuelet commented 3 years ago

this has been fixed. Testing required.

ganasp commented 3 years ago

What means "Testing required"? At the moment the situation for the primary model and secondary model for Listeria on the landingpage is still the same, the minimum values are displayed in the simulation view instead of the values for the parameters.

schuelet commented 3 years ago

The landingpage is not yet updated, sorry for that. Testing of the simulation configurator is still required but I better put that into another ticket.

mfilter commented 3 years ago

@schuelet: provide a link to the "other ticket" and update the landing page, so that @ganasp can test and this ticket can be closed.

schuelet commented 3 years ago

landingpage update request has been given to @llavall

ganasp commented 3 years ago

Testing LandingPage: Now the correct parameter values are displayed in the simulation view. Parameter values can be adjusted for new simulation setting with a desired number of decimal places.

schuelet commented 3 years ago

very good. I am closing this ticket then.