search

RakipInitiative / ModelRepository

Joint project of EFSA, Federal Institute For Risk Assessment, DTU and ANSES to create a online model repository.
GNU General Public License v3.0
2 stars 0 forks source link

RController not closing after Runner execution #341

Closed schuelet closed 3 years ago

schuelet commented 3 years ago

There are two issues I have discovered:

RController.close() is not enough to actually destroy the Rserve instance. If terminateRProcess() is declared public and called instead of close() in the RHandler, the process is actually terminated.

LibRegistry creates an RController to install packages, but never closes this controller.

I am not sure if any of this is intended or if we can tinker with it since that code comes from KNIME (albeit an old version).

Any suggestions?

schuelet commented 3 years ago

This has been fixed in https://github.com/SiLeBAT/FSK-Lab/pull/928