RakipInitiative / ModelRepository

Joint project of EFSA, Federal Institute For Risk Assessment, DTU and ANSES to create a online model repository.
GNU General Public License v3.0
2 stars 0 forks source link

Simulation Configurator Bug: Port object not available when user forgot to save new simulation #409

Closed schuelet closed 2 years ago

schuelet commented 2 years ago

If a user creates a new simulation in the Simulation Configurator JS and forgets to press the save key, the FSK-Portobject is lost or not created correctly (Port will not load):

image.png

I propose to either save automatically when the view is closed (if that is possible, maybe through an event when the user clicks outside the view) or blocking the close-and-apply function with a warning. At least, as a failsave, the changes to the simulations should be discarded in the event of "not saving", so that the portObject can be correctly re-created.

schuelet commented 2 years ago

fixed in https://github.com/SiLeBAT/FSK-Lab/pull/1044