RakipInitiative / ModelRepository

Joint project of EFSA, Federal Institute For Risk Assessment, DTU and ANSES to create a online model repository.
GNU General Public License v3.0
2 stars 0 forks source link

Execute failed: ("Exception"): null when writing file #468

Closed arno314 closed 1 year ago

arno314 commented 1 year ago

Rename the attached file to .fskx In fsk-lab read it with fsk-reader and write directly with fsk-writer. I get: Execute failed: ("Exception"): null when writing file

Trichinella_meatProduction_0.6.zip

schuelet commented 1 year ago

@arno314 This happens when the output filename is the same as the file currently opened by the Reader. I need to investigate why exactly the error is thrown, and there should definitely be a better error message, but I wonder if this behavior (don't overwrite the currently opened model) is worth keeping? Considering there could be something wrong with the new model file, better to keep the old one?.

arno314 commented 1 year ago

@schuelet Can knime have popups? Then we can have "Overwrite yes/no?". Alternatively, a backup file of the old file could be made, e.g. with .fskx.bak extension, and a warning that a file was overwritten and a backup created.

schuelet commented 1 year ago

Fixed. Now, the writing process will be done on a copy of the original file. This way, only after everything is completed the original file will be overwritten.