search

RakipInitiative / ModelRepository

Joint project of EFSA, Federal Institute For Risk Assessment, DTU and ANSES to create a online model repository.
GNU General Public License v3.0
2 stars 0 forks source link

packages.json: Information need to be preserved on KNIME Server #562

Open schuelet opened 11 months ago

schuelet commented 11 months ago

Packages.json, the file containing the libraries and environment information, needs to be immutable. Currently, when writing the FSKX file, the dependencies are collected during runtime and the original packages.json is overwritten with the information of the host system.

This should be thought through: When do we want the packages.json file to be updated? Probably only when the model script is modified?

Maybe we need to implement some sort of read-only mode to preserve the information that the original model creator provided. This is not trivial, maybe there are precedences for these kind of questions.

As short term solution: Make sure, the parameter.json is not modified when it is deployed on KNIME Server.

llavall commented 11 months ago

Interesting question! Here my two cents: What came first to my mind ist that this could be used to gather different configurations to be used on different OS. Background is that the packages on Windows and Linux might not be the same. I would preserve the original working configuration e.g. under Windows. On the KNIME Server then is a new JSON created in addition for LInux. Either the KNIME Server one is marked as our environment on server only or shipped as general Linux version. Depending on the user environment the fitting json is used.

If later on a new JSON configuration is created for the same OS it could be overwritten, but the old config not deleted but commented out to keep track? I can also image a user interaction to ask which configuration should be used before automatically creating the environment.