search

RandomFractals / vscode-snippets-viewer

Snippets viewer for VSCode
https://marketplace.visualstudio.com/items?itemName=RandomFractalsInc.snippets-viewer
GNU General Public License v3.0
8 stars 1 forks source link

Use global configuration target for toggles #64

Closed usernamehw closed 3 years ago

usernamehw commented 3 years ago

It makes no sense for the toggles to pollute workspace settings.

usernamehw commented 3 years ago

If you're not going to use updateWorkspaceSetting function - it can be deleted.

RandomFractals commented 3 years ago

I am on the fence about this change. I can see myself setting snippets prefs in global user settings for all projects and updating them based on toggles for a workspace.

Also, I am using config.updateWorkspaceSetting. That's why I added it :)

ecool commented 3 years ago

I like the idea of not using workspace settings, but if workspaceState does it based on the workspace (like I assume) and doesn't mess with the .vscode/settings.json file I would prefer that. Specifically for toggles from the extension.

Any global settings changes I like to manually set myself.

There is an extension I already have to use for a class with java that pollutes the settings file and annoys me to no end.