RareDevs / Rare

GUI for legendary. An Epic Games Launcher open source alternative
GNU General Public License v3.0
635 stars 21 forks source link

[BUG] Homeworld Remastered Collection - Launcher Crashing #376

Closed Zetta1Reid0 closed 5 months ago

Zetta1Reid0 commented 5 months ago

Platform : Windows 10 Rare Version : 1.10.11

Crash is not persistent. Sometimes the launcher opens / Sometimes it does not.

What I get from console :

Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
   at Epic.OnlineServices.Bindings.EOS_Platform_Tick(IntPtr handle)
   at Launcher.MainWindow.RunSteamCallbacks(Object stateInfo)
   at System.Threading.TimerQueueTimer.CallCallbackInContext(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.TimerQueueTimer.CallCallback()
   at System.Threading.TimerQueueTimer.Fire()
   at System.Threading.TimerQueue.FireNextTimers()
   at System.Threading.TimerQueue.AppDomainTimerCallback(Int32 id)
Application "Homeworld Remastered Collection" finished with "Process crashed"
Application "dcfccf8d965a4f2281dddf9fead042de" finished with "0"

Full Log :

[RareLauncher] INFO: Launching Rare version 1.10.11
[RareLauncher] INFO: Operating System: Windows
[LGDLFS] INFO: Using Rare's LGDLFS monkey
[Core] INFO: Using Rare's LegendaryCore monkey
[Core] INFO: Using config in C:\Users\ZR/.config/legendary
[RareLauncher] INFO: Your language is not supported
[Core] INFO: Trying to re-use existing login session...
[PreLaunchThread] INFO: Sync action: None
[PreLaunchThread] INFO: No sync action
[Core] INFO: Getting authentication token...
[RareLauncher] INFO: New connection
[RareLauncher] WARNING: Process crashed
[RareLauncher] INFO: Stopping server
[RareLauncher] INFO: Server disconnected
[RareLauncher] INFO: Launching Rare version 1.10.11
[RareLauncher] INFO: Operating System: Windows
[LGDLFS] INFO: Using Rare's LGDLFS monkey
[Core] INFO: Using Rare's LegendaryCore monkey
[Core] INFO: Using config in C:\Users\ZR/.config/legendary
[RareLauncher] INFO: Your language is not supported
[Core] INFO: Trying to re-use existing login session...
[PreLaunchThread] INFO: Sync action: None
[PreLaunchThread] INFO: No sync action
[Core] INFO: Getting authentication token...
[RareLauncher] INFO: New connection
[RareLauncher] WARNING: Process crashed
[RareLauncher] INFO: Stopping server
[RareLauncher] INFO: Server disconnected
loathingKernel commented 5 months ago

This looks to me like a crash of the game's launcher, rather than Rare. Unless the crash is related to Rare attaching to its process, this is most likely due to the launcher or your system. Can you try and see if it crashes with legendary? Legendary doesn't try to attach to the process like we do.

If the issue is with attaching to the launcher's process, we can add it to the exceptions.

Zetta1Reid0 commented 5 months ago

Yeah with Legendary 0.20.34 (latest release) it launches every time, no crashing.

loathingKernel commented 5 months ago

Looking at the error again, it correlates to the issue being that we attach to the process. Maybe we should not be doing that on Windows, since it is not important to have a log of the execution. For now and exception should be fine.

Zetta1Reid0 commented 5 months ago

I forgot to ,mention that the game has it's own launcher since it is a collection , thus attaching to it is kinda pointless since it forks 1 of the 3 games and closes after that anyway.