RasmusBrostroem / ConnectFourRL

0 stars 0 forks source link

Provide game object instead of just the board to players #80

Closed jbirkesteen closed 1 year ago

jbirkesteen commented 1 year ago

Currently, the select_action() method for players take the board in matrix representation as an argument. This, however, leads to problems when we need to define the TDAgent (and, actually, also the minimax-agent, which currently re-use some code from connectFour to work around this).
The following needs to be done:

This change should be fine, since the methods would usually be called from Env which has access to both players and connectFour.

RasmusBrostroem commented 1 year ago

Two minimax agents gives error in later stages of the game in place piece. Needs to be looked at more

jbirkesteen commented 1 year ago

Two minimax agents gives error in later stages of the game in place piece. Needs to be looked at more

The issue was that the initial value of the best_score did not depend on the loss_reward specified by the user, leading the player to choose column None when it couldn't avoid a loss. This was resolved in commit 88952cc.