Open sritchie73 opened 6 years ago
Related: #3007 foverlaps error message could be more informative
@sritchie73 thanks for this. I wrote foverlaps
in about 3-4 hrs (for EARL conference) and have not since looked at the features that've been left out .. Will take a look.
Some potentially helpful other references: bedops, bedtools, tidygenomics.
Hi, just wondering if maxgap, minoverlap is likely to be implemented soon? I think it would be a brilliant addition to avoid the conversion to GRanges object.
Hey @Al-Murphy that's definitely in "contributions welcome" status... happy to support however I can if you wanted to take up the gauntlet :smiley:
cc @arunsrinivasan who would be most familiar with that part of the code base & maybe better able to offer "mentor" support (not sure availability)
For those looking for not yet implemented functionality in foverlaps, please go to https://github.com/Rdatatable/data.table/issues/528#issuecomment-1880007663 and provide example code
There are a number of arguments in the
foverlaps()
function that are not yet implemented:type = "equal"
- #3416maxgap
minoverlap
Along with a few requested features:
minoverlap
foverlaps()
should work withoutsetkey()
beforehandfoverlaps()
could work with factor levelsThere will be a lesson on the
foverlaps()
function in the DataCamp course on joins, so I'm wanting to gauge whether its worth trying to implement these features before the course is released. Are there obvious technical barriers that have prevented these features from being implemented? Or has there been a lack of interest from the community and developers, e.g. given the availability ofGenomicRanges
?