search

Rdatatable / data.table

R's data.table package extends data.frame:
http://r-datatable.com
Mozilla Public License 2.0
3.62k stars 985 forks source link

Use a better approach for atime branch clean-up #6325

Open MichaelChirico opened 3 months ago

MichaelChirico commented 3 months ago 
          restoring branch because it is required in an atime performance test, which errored recently: https://github.com/Rdatatable/data.table/actions/runs/10149565942/job/28064770069?pr=6288
Error in value[[3L]](cond) : 
  Error in revparse_single(object, branch): Error in 'git2r_revparse_single': Requested object could not be found
 when trying to checkout 353dc7a6b66563b61e44b2fa0d7b73a0f97ca461

restoring (un-deleting) this branch should fix that error. please try to remember to not delete branches which have historical commits that are relevant to performance testing.

Originally posted by @tdhock in https://github.com/Rdatatable/data.table/issues/4501#issuecomment-2256694183

One idea is to keep all performance test commits in a dedicated atime branch. I'm not sure the exact playbook that will work here during PR review, but it does make sense to me as a way to make sure these commits are not ever removed.

tdhock commented 3 months ago

I'm not sure if it is possible, but at some point in the past Michael you suggested that we may be able to get commits even out of deleted branches? anyway I updated https://github.com/Rdatatable/data.table/wiki/Performance-testing with the current protocol (avoid deleting branches which may be relevant to performance testing).

MichaelChirico commented 3 months ago

I think I was mistaken, IIRC it required having checked out that commit locally at some point (so that you can still check it out even after git branch -d <branch>), but it doesn't work on CI where a "clean" checkout is done each time.

tdhock commented 3 months ago

ok that makes sense thanks for clarifying.