search

Rdatatable / data.table

R's data.table package extends data.frame:
http://r-datatable.com
Mozilla Public License 2.0
3.62k stars 985 forks source link

Explore {litedown} for rendering vignettes #6394

Open MichaelChirico opened 2 months ago

MichaelChirico commented 2 months ago

{knitr} requires R>=3.6.0; that means we can't render vignettes on our oldest supported versions of R (3.3, 3.4, 3.5).

@jangorecki sugegsts trying to render them instead with {litedown}:

https://github.com/Rdatatable/data.table/commit/d66e12bd884ee37d46952d65fe808a6a2a43b6c7#r145771409

https://cran.r-project.org/web/packages/litedown/index.html

https://github.com/yihui/litedown

{litedown} is only 5 months old:

https://github.com/yihui/litedown/commit/03db9970b290e3194942d5817140387ef5aebb6d

So we can expect to be among the first "major" users of the package if we make the switch -- I expect that to generate a decent amount of work filing/even fixing issues with upstream.

@jangorecki do you want to take the lead on owning the potential switch (exploring/validating/maintaining)?

jangorecki commented 1 month ago

IMO we could as well move away from pkgdown to new https://github.com/yihui/litedown/issues/24#issuecomment-2384933793 Pkgdown was causing extra burden with dependencies (new and many OS deps) and was at some point cached in a docker image, so it is not even updated in our CI for a longer while now.

ben-schwen commented 1 month ago

IMO we could as well move away from pkgdown to new yihui/litedown#24 (comment) Pkgdown was causing extra burden with dependencies (new and many OS deps) and was at some point cached in a docker image, so it is not even updated in our CI for a longer while now.

I would keep this as an extra issue, one step at a time!