Closed MichaelChirico closed 3 weeks ago
great thanks! according to https://github.com/Rdatatable/data.table/blob/master/GOVERNANCE.md#version-numbering "patch/hotfix development should occur on GitHub as z=odd (1.15.1) and release to CRAN as z=even (1.15.2)." but I see 1.15.2 in https://github.com/Rdatatable/data.table/blob/patch-1.16.2/DESCRIPTION so could you please change to 1.15.1?
May I suggest/request that https://github.com/Rdatatable/data.table/pull/6442 be included? That bug is a show-stopper for just about anybody using options(datatable.prettyprint.char=)
. (I apologize if this comment is out of line.)
May I suggest/request that #6442 be included? That bug is a show-stopper for just about anybody using
options(datatable.prettyprint.char=)
. (I apologize if this comment is out of line.)
yep it's in the milestone already:
Hi @TysonStanley! The patch branch 1.16.2 is ready for release I think :)
https://github.com/Rdatatable/data.table/tree/patch-1.16.2
Thank you!
@MichaelChirico great! Will get this submitted this week.
Thanks, been traveling so working on this now. Did most of the checks, which are passing at this point, but I'm still replicating the NOTE
that we see on CRAN too:
Running ‘knitr.R’ [1s/1s]
Comparing ‘knitr.Rout’ to ‘knitr.Rout.save’ ...28,38d27
<
< ```
< ## x y z
< ## <int> <int> <int>
< ## 1: 1 4 7
< ## 2: 2 5 8
< ## 3: 3 6 9
< ```
<
< ``` r
52,62d40
< ```
<
< ```
< ## x y z a
< ## <int> <int> <int> <int>
< ## 1: 1 4 10 1
< ## 2: 2 5 11 1
< ## 3: 3 6 12 1
Looks like the difference is that DT[, z := 7:9]
is printing in the knitr
output.
< ## x y z
< ## <int> <int> <int>
< ## 1: 1 4 7
< ## 2: 2 5 8
< ## 3: 3 6 9
Yea, that shouldn't happen 🙈
Not sure why it's not showing up in CI checks at all. It's a note on Linux and windows on CRAN and it showed up on MacOS for me here.
Hi, just wondering if there was an update on expected timeline for release - have been eagerly awaiting Rdatatable/data.table#6452 to be released on CRAN as that intermittent segfault has been annoying to work around in our prod systems (and corp security frowns on github installs)
@tanho63 I suggest you do what I did: downgrade. It's not awesome or desirable, but it's a far-more-stable approach than adding workarounds in production systems.
(I'm not a dev here, I'm also eagerly awaiting 1.16.2. I deliberately tested our prod systems against 1.16.0, found some bugs, and am holding back until our tests come back clean.)
There is one issue remaining on the patch release that we are solving. As soon as that is solved, everything else about the release is ready to go.
@tanho63 we're having a bit of trouble with #6509 because it only shows up on some systems and happens non-interactively so the usual debugging toolkit is unavailable.
if you want to expedite release please try your hand at fixing 😁
Great, will submit later today/tomorrow
Patch was just accepted but I'm away from my computer until tonight. Will update the branch and release then.
We've picked up a number of issues we should handle in a patch release already.
I've begun branch
patch-1.16.2
to keep track of the changes.So far it includes: