ReVanced / revanced-documentation

🗄 Collection of all ReVanced documentation
https://revanced.app
GNU General Public License v3.0
271 stars 44 forks source link

Documentation for MicroG/GmsCore #37

Closed ECHOSUD closed 8 months ago

ECHOSUD commented 8 months ago

There is very little information within the Revanced Manager, reddit or the github for where users should find support for MicroG/GmsCore. The offical fork from the Revanced Project of the GmsCore is itself a fork from oSumAtrIX fork, which has been archived. It is unclear if the Revanced Project's fork is also discontinued, considering it is a single release that was immediately archived. Meanwhile inotia00 fork of Vanced MicroG has continued to be updated, while to the average user it appeared to also be discontinued from before the Revanced Project's fork was established. Is updating MicroG/GmsCore just not important for a user?

Ushie commented 8 months ago

It's not important, as long as it works, it works, once it stopped working then we already have our fork to replace it with

MicroG is only relevant for a single patch, hence why there's no documentation for it, it's not important in ReVanced itself, only in that specific patch which is considered separate from ReVanced when it comes to documentation

oSumAtrIX commented 8 months ago

Just like @Ushie said, GmsCore has nothing to do with ReVanced. The only relationship to GmsCore is created via a single patch that makes target apps use GmsCore. The docs are agnostic towards patches by design. In regards of GmsCore, ReVanced has been the only late fork of GmsCore that achieved compatibility with a minimum amount of changes and thus is the best candidate for future upstream merges. Heavily forked versions such as Vanced MicroG and co. are victim of the past because of being heavily forked and this is a fate that ReVanced will avoid to pursue with the current fork in place with as little as changes necessary as possible

ECHOSUD commented 8 months ago

Ah I see. I moved to Revanced's fork of GmsCore around July since it was part of the Revanced Project on github, compared to the Vanced MicroG I was using from ~2022.

My biggest dissapointmets with the Revanced Project fork comapred to the Vanced MicroG:

Based on your comments this seems intended as it is more stable than a highly customised version, and no concerns with updating for security reasons.

Ushie commented 8 months ago

Those issues would eventually be tackled, but for the time being we're only doing the minimum changes necessary to make it easier to downstream changes

oSumAtrIX commented 8 months ago

Apk size is due to multiarch apk, permission request is I think what upstream also does, otherwise needs a fix and it is clear that the fork has not been discontinued as it is not in an archived state and the project is active.