search

RedHatSatellite / soe-ci

Jenkins integration scripts for use in an SOE Build Factory based on Red Hat Satellite 6.
GNU General Public License v3.0
42 stars 32 forks source link

Jenkins Pipeline hard-codes the config groovy files #95

Open jeichler opened 7 years ago

jeichler commented 7 years ago

currently:

def loadEnvVars() {
  loadEnvVarsFromFile("script-env-vars.groovy")
  if (params.PUPPET_ONLY == true) {
    loadEnvVarsFromFile("script-env-vars-puppet-only.groovy")
  } else {
    loadEnvVarsFromFile("script-env-vars-rpm.groovy")
  }
}

if you want to use the Jenkinsfile for example with el6 and el7, you need to use another branch or copy it. that's far from good.

PR is coming this week to resolve this.

jeichler commented 7 years ago

for the reviewers, I hope that you especially check the documentation, maybe even you could check it @ericzolf since you pointd out some missing or unclear things.

for testing it might be worth to create 2 jobs, one which pulls, one which executes the pipeline - following the documentation should lead to a successfully running build.

jeichler commented 7 years ago

@ericzolf it has been merged, so it should be sufficient for you to test the jenkins_pipeline branch and/or read the https://github.com/RedHatSatellite/soe-ci/blob/jenkins_pipeline/README.md

pcfe commented 6 years ago

this has been working fine for many months in RedHatSatellite:jenkins_pipeline @ericzolf @nstrug is there anything that speaks against finally enabling pipelines and deprecating the old non-pipeline way?