ReimuNotMoe / ydotool

Generic command-line automation tool (no X!)
GNU Affero General Public License v3.0
1.52k stars 82 forks source link

Make the help message about daemon not running include the service name #218

Open C0rn3j opened 10 months ago

C0rn3j commented 10 months ago
% ydotool type s
failed to connect socket `/run/user/1000/.ydotool_socket': No such file or directory
Please check if ydotoold is running.

This is a bit confusing, the daemon's service is named ydotool, but the daemon binary itself is ydotoold, which the help message suggests to check is running.

ydotoold.service which was the first thing I tried blindly before resorting to reading package source files.

Would it be possible to either rename the service to ydotoold, which would probably make the most sense but be the most breaking, or perhaps making the help message more obvious in regards to the service name?

"Could not connect to ydotoold - is the user unit ydotool.service running?"

With the second part of the message possibly dependent on whether or not systemd is running.

Paiusco commented 6 months ago

I already changed the name always to ydotoold for the daemon from #226

Although you ask to be precise to mention if ydotoold.service is running, I don't agree to hardcode it, as it can be running on any other init system or even manually. Someone has to start the daemon, but not necessarily systemd