RemoteControlledArty / RemoteControlledArtillery

ARMA III Mod
1 stars 1 forks source link

Functions - Optimized MarkerLoop and renamed it to markerHandler #1

Closed Tapawingo closed 4 months ago

Tapawingo commented 4 months ago

When merged this pull request will:

Tapawingo commented 4 months ago

Requires testing in Singleplayer, Self-Hosted Multiplayer and Dedicated environments before merge.

realfluffyuwu commented 4 months ago

Looks much better than my implementation, I'm not sure why I didn't use mission event handlers from the beginning, I probably ran into some Stupid Arma Problem and brute forced my way around it

Tapawingo commented 4 months ago

It will need Testing to make sure no fuckery arises from Locality issues but otherwise I see no issues with it

I don't think locality will be a issue as the resulting array is streamed to all clients on the network. I believe general functionality is where issues are more likely to arise as I have not taken the time to read through all of your code. There is a high likelihood I've accidentally removed intended functionality without realizing it.

That's not to say locality shouldn't be tested, rather, I don't think it should be the priority. Also I would've tested it myself, however, I'm a full-time university student and I got a lot of work this week so I just haven't had the time 😅

Tapawingo commented 4 months ago

It's now been tested by both me and @RemoteControlledArty in singleplayer and works as intended. It's ready to be merged. Before the next release though I recommend doing a full test in a dedicated environment making sure that everything works.