search

RethinkRobotics / baxter

Baxter Research Robot SDK
www.rethinkrobotics.com/sdk
BSD 3-Clause "New" or "Revised" License
71 stars 65 forks source link

Enable robot (e-stop check) 7396 #121

Closed rethink-rlinsalata closed 11 years ago

rethink-rlinsalata commented 11 years ago

Enable Robot now checks for E-Stop Asserted before trying to enable. Starts helping to distinguish between enable fails because of E-Stop, connection, or HW error. Enable robot also now gives more verbose feedback (so user knows what it is doing).

Corresponds to trac: http://www/trac/ticket/7396

rethink-kmaroney commented 11 years ago

This should definitely be helpful.

One comment - We should address when the robot cannot resolve the client. ie. when a user does not set their ROS_IP or sets an unresolvable ROS_HOSTNAME. Test this by unsetting the chosen method in a new shell. This results in the uninformative:

OSError: [Errno 110] Failed to enable robot

Is there another ticket already addressing this? This applies to the enable, disable and reset commands.

rethink-kmaroney commented 11 years ago

Addressed the above comment in #123.