RethinkRobotics / baxter

Baxter Research Robot SDK
www.rethinkrobotics.com/sdk
BSD 3-Clause "New" or "Revised" License
71 stars 64 forks source link

Getch removals as means of exiting #136

Closed rethink-rlinsalata closed 10 years ago

rethink-rlinsalata commented 10 years ago

This commit removes use of our iodevices.getch() function as a means of handling exiting.

Catching Ctrl-C in getch before was not robust to signals sent when not inside the getch() timeout nor to other ROS shutdown signals. Instead, examples that used getch() before implement a clean_shutdown function, which is used as a callback for the rospy.on_shutdown() signal handler.

This PR may need a follow-up commit for consistency after some slightly variations in implementing this callback are reviewed.

rethink-kmaroney commented 10 years ago

Looks good.