search

RethinkRobotics / baxter

Baxter Research Robot SDK
www.rethinkrobotics.com/sdk
BSD 3-Clause "New" or "Revised" License
71 stars 65 forks source link

Modify 0.7.0 rosinstall file to reflect 0.7.0 branches #167

Closed brawner closed 10 years ago

brawner commented 10 years ago

The rosinstall file in the 0.7.0 branch installs packages from the master branch, which no longer refer to the 0.7.0 sdk. It would be great if it could be updated accordingly.

Don't worry, we'll upgrade soon, but still...

Thanks Stephen

rethink-rlinsalata commented 10 years ago

Agreed - that came up (having the rosinstall on each branch correspond appropriately), though it slipped through the cracks and we forgot to go back and make the change.

Quick question, do you ever make changes inside the actual Baxter SDK repos (baxter_*)? (or users who would use the branch rosinstall files) And would you be using the branch-rosinstall file on a new install/checkout or to switch an old, existing checkout?

(For the sake of documenting this somewhere, see below for an overly-detailed analysis on why:) One design decision that came up was whether we should make the rosinstalls use the "old-style" SSH URI's for the git repos (git@github.com:) or should they use the "1.0+ style" HTTPS URI's (https://github.com/_).

The ramifications are that if you try to merge a rosinstall from one to the other (that has the same repos as already exist), the difference in git URI's will make git (and wstool) think that they are two different repos and one must be deleted to replace the other. This means when users do update to the new version, they'll be SOL if they made any modifications in the baxter_* repos.

Basically, if the user is doing a fresh install, they might as well use the new-style. If they are using the branch rosinstall file to update an old or existing checkout, then the old-style would be more appropriate.

SO, the questions are: Do users modify the baxter repos in the first place? And are they using the branch rosinstall files to switch between existing checkouts, or for new installs?

brawner commented 10 years ago

Yes we make changes to the baxter directories, typically when adding new launch files, or modifying previous ones. The most obvious one to me is baxter_moveit_config.

However, I think for new releases, people in our lab have habit of just creating a new catkin workspace and performing a fresh install.

I doubt merging a new rosinstall file on github with a working catkin workspace will happen all that often. I doubt people even perform a wstool update, but that's just us.

RethinkRoboticsInc commented 10 years ago

+1