search

RethinkRobotics / baxter_simulator

Gazebo Simulation interface for the Baxter Research Robot
http://sdk.rethinkrobotics.com/wiki/Baxter_Simulator
BSD 3-Clause "New" or "Revised" License
84 stars 94 forks source link

Fix compilation on Ubuntu 18.04 w ROS Melodic #130

Closed roncapat closed 2 years ago

roncapat commented 5 years ago

On systems with qt-moc versione 5 or above, MOC generation fails.

This patch excludes ros includes (and thus the problematic boost includes) from sources during MOC generation. This patch also migrates to std::shared_ptr, as it seems that URDF library migrated to them, leading to build errors.

roncapat commented 4 years ago

@knorth55 could you please check? The only difference from your review is the conditional inclusion of the header <memory>

roncapat commented 4 years ago

PR #129 is also strictly related. Use of auto is better IMHO, but not sure if the header is still explicitly required or not.

knorth55 commented 4 years ago

Oh, I forgot to tell you to include <memory>. Thank you so much! I did the same thing in my environment, and I confirmed it works.

knorth55 commented 4 years ago

By the way, this repository is no longer maintained, but no one succeeded the release and maintenance permission. There is a discussion about the release of this repository. If you have time, please take a look. https://discourse.ros.org/t/baxter-release-permissions/8705

roncapat commented 4 years ago

Thank you for linking.

roncapat commented 2 years ago

Closing for obsolescence